Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: actually enable husky/lint-staged #2999

Merged
merged 1 commit into from
Oct 26, 2022
Merged

build: actually enable husky/lint-staged #2999

merged 1 commit into from
Oct 26, 2022

Conversation

MarshallOfSound
Copy link
Member

Husky would be great if we actually set it up 🙃

@MarshallOfSound MarshallOfSound requested a review from a team October 26, 2022 19:33
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2999 (6bb661f) into main (b97c906) will increase coverage by 11.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2999       +/-   ##
===========================================
+ Coverage   62.68%   74.24%   +11.56%     
===========================================
  Files          65       67        +2     
  Lines        2125     2178       +53     
  Branches      425      436       +11     
===========================================
+ Hits         1332     1617      +285     
+ Misses        614      354      -260     
- Partials      179      207       +28     
Impacted Files Coverage Δ
packages/api/core/src/api/start.ts 64.04% <0.00%> (ø)
packages/api/core/src/api/publish.ts 68.42% <0.00%> (ø)
packages/api/core/src/util/plugin-interface.ts 31.11% <0.00%> (ø)
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <0.00%> (ø)
packages/maker/deb/src/MakerDeb.ts 95.45% <0.00%> (+0.45%) ⬆️
packages/maker/rpm/src/MakerRpm.ts 95.45% <0.00%> (+0.45%) ⬆️
packages/maker/flatpak/src/MakerFlatpak.ts 79.16% <0.00%> (+1.89%) ⬆️
packages/utils/async-ora/src/ora-handler.ts 81.81% <0.00%> (+3.03%) ⬆️
packages/api/core/src/util/publish-state.ts 92.30% <0.00%> (+5.12%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b97c906...6bb661f. Read the comment docs.

@VerteDinde VerteDinde merged commit 23f56d0 into main Oct 26, 2022
@VerteDinde VerteDinde deleted the fix-husky branch October 26, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants