-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: migrate to lerna from bolt #3058
Conversation
7e4591c
to
510c942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing this work! 👏 Tested on Windows and the linking is working great. Let's cut a new release of Forge shortly after this is merged, just to double verify all of the publishing steps work as expected.
Hey, Juri from the Nx/Lerna core team here 👋 Since Forge is open source, it would also be eligible for free Nx Coud remote caching. Is that something you're interested in? The main advantage is that caching is not just locally on developer machines, but you can also leverage it on CI & thus, obviously speed up things. |
6e0814a
to
6bc6e4b
Compare
6bc6e4b
to
37cb86d
Compare
48beff8
to
1eccbee
Compare
Hi Juri, thank you for the kind offer! It would be great to set up caching on our CI. I would be happy to help with any changes that are needed to enable the feature :) |
@georgexu99 Awesome! Let me have a co-worker of mine push up a PR and we can keep the discussion going based on the required changes :) |
@juristr Hey Juri! Is there anything I can do to help with the PR? |
@georgexu99 I've talked to a co-worker of mine last week. They will send a PR soon :) We can then get the discussion going based on that :) |
@georgexu99 Can you join our community slack so we can talk privately regarding getting the cloud workspace setup under your account? If you have already joined, feel free to DM me on there. My name is Craigory, should see Nx Core Team in it as well. I work with Juri :) |
This PR changes the monorepo package management tool to Lerna from Bolt. Lerna also works with yarn workspaces and nx so we use those as well. This gives us several benefits, including but not limited to:
cached tests !!! (nx);
dependency hoisting and symlinking (yarn workspaces);
a newer version of package management tool (bolt version was very old), and,
the ability to leverage lerna version and lerna publish, replacing our old version bump and publish scripts.
NOTE: this PR may be easier to review going commit by commit
Summarize your changes:
Fixes #3072