Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: improve lerna publish process #3082

Merged
merged 4 commits into from
Nov 21, 2022
Merged

build: improve lerna publish process #3082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e26f83c
build: improve lerna publish process
erickzhao Nov 16, 2022
bb04a4c
don't bother with the root package.json version
erickzhao Nov 16, 2022
0ffbb72
less silly name
erickzhao Nov 16, 2022
2da0840
remove package.json comment
erickzhao Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,7 @@ Here are some things to keep in mind as you file pull requests to fix bugs, add
- Make sure the tests pass with `lerna run test`
- Run `git clean -fdx` - this will ensure unneeded build files (and potentially sensitive files) are not included in the npm package.
- Ensure that you are logged into npm via command line (`npm login`)
- `lerna publish --force-publish`
- **running this command without the `--force-publish` flag will only publish packages that have changes since
last release**.
- for beta releases, select `custom prerelease` when prompted, and enter `y` to increment the beta version.
- version numbers should be an un-prefixed [semantic version](https://semver.org/) number (e.g. `6.0.0-beta.67)
- Run `yarn lerna:publish`, which will run the `lerna publish` command with a necessary set of flags.
- The script will then ask you for your `npm` OTP password.
- The script will commit the changes automatically. Run `git log` to confirm that the changes have been
committed.
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "electron-forge",
"version": "6.0.1",
"version": "0.0.0-development",
"private": true,
"license": "MIT",
"engines": {
Expand All @@ -16,6 +16,7 @@
"docs:generate": "yarn docs:plugin && node --max-old-space-size=8192 -r ts-node/register ./tools/gen-docs.ts",
"docs:plugin": "cd ./tools/doc-plugin && yarn build",
"docs:deploy:build": "yarn docs",
"lerna:publish": "lerna publish --force-publish --conventional-commits --no-changelog",
"lint": "prettier --check . && eslint .",
"lint:fix": "prettier --write .",
"link:prepare": "lerna exec -- node ../../../tools/silent.js yarn link --link-folder ../../../.links --silent --no-bin-links",
Expand Down