-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): pass missing user-defined hooks to packager #3123
Merged
erickzhao
merged 1 commit into
electron:main
from
erikian:fix/user-defined-aftercomplete-hooks
Jun 15, 2023
Merged
fix(package): pass missing user-defined hooks to packager #3123
erickzhao
merged 1 commit into
electron:main
from
erikian:fix/user-defined-aftercomplete-hooks
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
force-pushed
the
fix/user-defined-aftercomplete-hooks
branch
from
December 26, 2022 17:27
27dc3c9
to
3fab30b
Compare
There were other hooks not being passed to packager, so I've added them too |
erikian
changed the title
fix(package): pass user-defined
fix(package): pass user-defined hooks to packager
Dec 26, 2022
afterComplete
hooks to packager
erickzhao
approved these changes
Jan 20, 2023
erickzhao
requested changes
Feb 7, 2023
erikian
changed the title
fix(package): pass user-defined hooks to packager
fix(package): pass missing user-defined hooks to packager
Feb 10, 2023
erikian
force-pushed
the
fix/user-defined-aftercomplete-hooks
branch
from
February 21, 2023 22:26
3fab30b
to
fed1cc2
Compare
erikian
force-pushed
the
fix/user-defined-aftercomplete-hooks
branch
from
February 22, 2023 02:25
fed1cc2
to
1822873
Compare
erikian
force-pushed
the
fix/user-defined-aftercomplete-hooks
branch
from
February 22, 2023 21:32
1822873
to
e2c28b2
Compare
erikian
requested review from
MarshallOfSound and
erickzhao
and removed request for
erickzhao and
MarshallOfSound
February 22, 2023 21:53
3 tasks
Is the afterCopy hook is one of those? |
@jhetuts no, |
MarshallOfSound
approved these changes
Jun 15, 2023
VerteDinde
approved these changes
Jun 15, 2023
erickzhao
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Currently,
afterComplete
hooks defined in the Forge configuration are not being passed to electron-packager, so the following code has no effect:The existing tests for hooks cover only Forge-specific hooks, not hooks from electron-packager, so I didn't add any tests.