Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use fallback renderer for any DEBUG vars #3135

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jan 10, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Uses the non-TTY renderer anytime the DEBUG environment variable has a value rather than only when it contains electron-forge. This is useful when debugging transient dependencies such as electron-packager or electron-osx-sign.

@erickzhao erickzhao requested a review from a team January 10, 2023 01:19
@erickzhao erickzhao merged commit 6a118c6 into main Jan 10, 2023
@erickzhao erickzhao deleted the debug-all branch January 10, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants