Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct platform paths for artifacts in dryRunResume #3184

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

VerteDinde
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Fixes a path issue within publisher -> dryRunResume. If a dry run occurred on one platform (e.g. Windows), the path slashes will retain their original formatting, even if the resume action is called on a platform with different path syntax (e.g. Linux).

This PR normalizes the path formats to fix whatever format is needed for dryRunResume.

@VerteDinde VerteDinde requested a review from a team as a code owner March 7, 2023 23:44
@VerteDinde VerteDinde requested a review from a team March 7, 2023 23:44
@VerteDinde VerteDinde added this pull request to the merge queue Mar 7, 2023
Merged via the queue into main with commit 1bf6626 Mar 7, 2023
@VerteDinde VerteDinde deleted the fix-paths-in-publisher-dry-run branch March 7, 2023 23:59
@dsanders11
Copy link
Member

Looks like this didn't fix the issue over on Fiddle. I think the normalized path needs to be updated in makeResult, so that publishers only see normalized paths. Otherwise each publisher implementation will have to do it themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants