Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-fuses): resetAdHocDarwinSignature rules on Mac #3190

Merged
merged 2 commits into from
Mar 10, 2023
Merged

fix(plugin-fuses): resetAdHocDarwinSignature rules on Mac #3190

merged 2 commits into from
Mar 10, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Mar 10, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Fixing a couple of whoopsies from #3132:

  • resetAdHocDarwinSignature logic for platform=mas
  • a very minor typo in the README that is not worth a separate PR IMO.

@erikian erikian marked this pull request as ready for review March 10, 2023 11:23
@erikian erikian requested a review from a team as a code owner March 10, 2023 11:23
@erickzhao erickzhao added this pull request to the merge queue Mar 10, 2023
Merged via the queue into electron:main with commit 4676826 Mar 10, 2023
@Cefold Cefold mentioned this pull request Jul 6, 2023
Closed
3 tasks
@renovate renovate bot mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikian @erickzhao