Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-vite): auto-update server.port #3201

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

caoxiemeihao
Copy link
Member

@caoxiemeihao caoxiemeihao commented Mar 31, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fix #3198

TODO:

  • update related test

@caoxiemeihao caoxiemeihao requested a review from a team as a code owner March 31, 2023 14:52
@malept
Copy link
Member

malept commented Mar 31, 2023

PR title should be

feat(plugin-vite): auto-update `server.port`

To be clear about which module the PR is related to in the release notes.

@erickzhao erickzhao changed the title feat: auto update server.port #3198 feat(plugin-vite): auto-update server.port Mar 31, 2023
@GitMurf
Copy link

GitMurf commented Apr 24, 2023

What is the status here? If this is complete and will be in the next release then I can close out my GH Issue here: #3198

@erickzhao erickzhao merged commit 78e57ef into electron:main Apr 24, 2023
@caoxiemeihao caoxiemeihao deleted the feat/auto-update-port branch April 25, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants