Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): add support for async Forge configs #3288

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

VerteDinde
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The test suite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR modifies the getForgeConfig() method to accept asynchronous configs.

@VerteDinde VerteDinde requested a review from a team as a code owner August 3, 2023 04:58
@VerteDinde VerteDinde changed the title feat (package): add support for async Forge configs feat(package): add support for async Forge configs Aug 3, 2023
packages/api/core/src/util/forge-config.ts Outdated Show resolved Hide resolved
@VerteDinde VerteDinde merged commit f6dce52 into main Aug 8, 2023
3 checks passed
@VerteDinde VerteDinde deleted the async-forge-config branch August 8, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants