Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-fuses): clear test TODOs #3306

Merged
merged 1 commit into from
Aug 20, 2023
Merged

test(plugin-fuses): clear test TODOs #3306

merged 1 commit into from
Aug 20, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Aug 19, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Now that the Fuses plugin is published to npm, the test app doesn't need to install it from the filesystem anymore. I've also updated the output directory path to make it consistent across all platforms/architectures (this was already implemented here, but it wasn't working because of a bug with the afterComplete hook that's been fixed since v6.2.1).

This will hopefully solve that nasty error we've been getting when running this test locally 🤞🏼

@erikian erikian requested a review from a team August 19, 2023 20:59
@erikian erikian requested a review from a team as a code owner August 19, 2023 20:59
@erikian erikian merged commit 7d5e748 into main Aug 20, 2023
4 checks passed
@erikian erikian deleted the test/fuses-plugin branch August 20, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants