Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add forge upgrade reminder #3530

Closed
wants to merge 0 commits into from

Conversation

DevanceJ
Copy link
Contributor

@DevanceJ DevanceJ commented Mar 11, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
    I need to work on adding a test or two to cover my changes.
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #3091
Add a check that informs the developer about a new Forge version and asks them to bump their packages when creating builds.

@DevanceJ DevanceJ requested a review from a team as a code owner March 11, 2024 22:03
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I feel like adding a reminder on every yarn start is a bit too much.

I personally wouldn't mind hooking directly into update-notifier as you stated in your issue comment earlier.

@DevanceJ
Copy link
Contributor Author

How can I install a dependency in /packages/api/cli. When I used yarn add update-notifier and then tried yarn build I got multiple errors.

image

@DevanceJ DevanceJ closed this Apr 16, 2024
@DevanceJ DevanceJ force-pushed the feat/add-upgrade-reminder branch from 5adc9dc to fc9af7c Compare April 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upgrade reminder
2 participants