Skip to content

Conversation

@himself65
Copy link
Contributor

@himself65 himself65 commented Jul 6, 2025

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Remove ts-node as we don't need it

@himself65 himself65 requested a review from a team as a code owner July 6, 2025 10:46
@erickzhao erickzhao self-requested a review July 7, 2025 17:01
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @himself65, thanks for opening this PR. For the templates, I think we can actually remove the ts-node dependency altogether after #3907 landed.

I initially tried going with the tsx method and it was ultimately pretty complicated so I replaced it with jiti: #3881

@himself65
Copy link
Contributor Author

Yeah, I see we are actually not using it. let me remove it

@himself65 himself65 changed the title fix: use tsx instead of ts-node by default fix: remove unused ts-node in template Jul 7, 2025
@himself65 himself65 requested a review from erickzhao July 7, 2025 18:56
@erickzhao erickzhao added this pull request to the merge queue Jul 7, 2025
Merged via the queue into electron:main with commit 27467a0 Jul 7, 2025
11 checks passed
@himself65 himself65 deleted the tsx branch July 7, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants