Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-fetch, fetch-mock, & electron-packager #431

Merged
merged 2 commits into from
Feb 14, 2018

Conversation

malept
Copy link
Member

@malept malept commented Feb 8, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #422.

@malept
Copy link
Member Author

malept commented Feb 13, 2018

@MarshallOfSound this now fixes #422 (rcedit was updated)

@malept malept merged commit dee72fd into master Feb 14, 2018
@malept malept deleted the upgrade-dependencies-6 branch February 14, 2018 16:07
@digifico
Copy link

Hey @MarshallOfSound
When we could expect new release with this changes?

@malept
Copy link
Member Author

malept commented Feb 15, 2018

Released in 5.1.1.

@mark-schaal
Copy link

mark-schaal commented Apr 25, 2018

@malept or @MarshallOfSound did this change in release 5.2.0? Using that package I'm seeing similar rcedit issues for setting icons as identified in #422.

@malept
Copy link
Member Author

malept commented May 3, 2018

Nope. That error is a pretty generic error, and I've tried to make it better with electron/rcedit#74, which is now available in rcedit 1.1.0.

dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
Co-authored-by: malept <electron-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants