-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V6 API #433
Merged
Merged
V6 API #433
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
c31417e
temp
MarshallOfSound e032201
Start working in new package structure
MarshallOfSound c17a6bb
Example maker
MarshallOfSound 7de5c07
All makers implemented and tests passing on darwin
MarshallOfSound c5617fd
Add v6 branches to travis config
MarshallOfSound bf0a3bd
Add v6 branches to appveyor config
MarshallOfSound c4213b8
Gitignore _old
MarshallOfSound 935d46b
Remove FIXME comments
MarshallOfSound 878ef65
Remove from CI branch whitelist
MarshallOfSound 36f1cdf
Install bolt on docker
MarshallOfSound 2721c47
Add to whitelist
MarshallOfSound 6c45c53
Fix bolt usage on CI
MarshallOfSound 406d78d
Run bolt build on CI
MarshallOfSound b7ca5c6
Fix tests on CI
MarshallOfSound 34b2c60
Fix linting
MarshallOfSound 1a3d124
Fix CI
MarshallOfSound 1fef26e
Make publishers work and add specs
MarshallOfSound d34efb3
Docs template
MarshallOfSound 07dd4ac
Initial docs
MarshallOfSound bcb37df
update plugin interface to support resolving strings
MarshallOfSound 2374803
more docs
MarshallOfSound 70fb767
add deps and scripts
MarshallOfSound 5b86b64
send makeResults instead of flatten artifacts list
MarshallOfSound d17d02c
feat(publisher): Allow to configure channel for ERS (#456)
gossi 71ca7e5
fix(publisher): call resolve() when electron-release-server publisher…
malept 4644b85
Fix publisher tests
malept abd9b1a
Remove stray console statement
malept 3263f85
v6-api is a PR now, no need to explicitly add to CI
malept 976b670
Add top level license
MarshallOfSound 75ad202
Change Maker/Publisher syntax so that they can be constructed with a …
MarshallOfSound 2bb6222
Fix custom init
MarshallOfSound 0cf132d
Add missing semi
MarshallOfSound f68c3a3
Use absolute path for custom init to avoid runnig npm link on windows
MarshallOfSound ac04cf9
Fix appx test reference to fixture key file
MarshallOfSound 6c6c798
Remove shell completion support (#447)
malept 2f614dc
install new beta tagged bolt on CI
MarshallOfSound 3d27421
Fix testing snap building in Travis
malept 74e160c
fix remove error
MarshallOfSound de2929c
Fix config passing in tests
MarshallOfSound 1b924da
fix search order
MarshallOfSound File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"sourceMaps": "inline", | ||
"plugins": [ | ||
"@babel/plugin-proposal-class-properties", | ||
"@babel/plugin-proposal-object-rest-spread" | ||
], | ||
"presets": [ | ||
[ | ||
"@babel/preset-env", | ||
{ | ||
"targets": { | ||
"node": "6" | ||
} | ||
} | ||
] | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
dist | ||
node_modules | ||
docs | ||
.nyc_output | ||
coverage | ||
npm-debug.log | ||
dist | ||
yarn-error.log | ||
packages/.old |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
8.9.1 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
_book | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# Electron Forge |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Summary | ||
|
||
* [Introduction](README.md) | ||
* [Configuration](config.md) | ||
* [CLI](cli.md) | ||
* [Import](cli.md#import) | ||
* [Init](cli.md#init) | ||
* [Install](cli.md#install) | ||
* [Lint](cli.md#lint) | ||
* [Make](cli.md#make) | ||
* [Package](cli.md#package) | ||
* [Publish](cli.md#publish) | ||
* [Start](cli.md#start) | ||
* [API Docs](https://docs.electronforge.io) | ||
* [Plugins](plugins.md) | ||
* [Webpack](plugins.md#webpack) | ||
* [Electron Compile](plugins.md#electron-compile) | ||
* [Parcel](plugins.md#parcel) | ||
* [Makers](makers.md) | ||
* [AppX](makers.md#appx) | ||
* [Deb](makers.md#deb) | ||
* [DMG](makers.md#dmg) | ||
* [Flatpak](makers.md#flatpak) | ||
* [RPM](makers.md#rpm) | ||
* [Snapcraft](makers.md#snap) | ||
* [Squirrel.Windows](makers.md#squirrel) | ||
* [Wix MSI](makers.md#wix) | ||
* [Zip](makers.md#zip) | ||
* Publishers | ||
* [Electron Release Server](publisher/ers.md) | ||
* [GitHub](publisher/github.md) | ||
* [S3](publisher/s3.md) | ||
* [Snapcraft](publisher/snap.md) | ||
* [Extending Electron Forge](extend.md) | ||
* [Writing Plugins](extend.md#writing-plugins) | ||
* [Writing Makers](extend.md#writing-makers) | ||
* [Writing Publishers](extend.md#writing-publishers) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"plugins": ["theme-api", "panel", "collapsible-menu", "ace"], | ||
"pluginsConfig": { | ||
"theme-api": { | ||
"theme": "dark" | ||
} | ||
}, | ||
"styles": { | ||
"website": "styles/website.css" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
# Electron Forge CLI | ||
|
||
{% method %} | ||
## Installation | ||
|
||
Electron forge's CLI is separate from the core module, to install it you will | ||
have to use the `@electron-forge/cli` module from NPM. | ||
|
||
{% sample lang="sh" %} | ||
```sh | ||
# NPM | ||
npm i -g @electron-forge/cli | ||
|
||
# Yarn | ||
yarn global add @electron-forge/cli | ||
``` | ||
|
||
{% endmethod %} | ||
|
||
## Overview | ||
|
||
At a high level the CLI module is just a proxy to the raw | ||
[API](https://docs.electronforge.io) commands. Almost all the configuation | ||
is still done in your [Forge Config](config), the CLI just provides a handy | ||
way to trigger all the core functionality of Electron Forge (and you should | ||
definitely use it). | ||
|
||
## Commands | ||
|
||
Please note these commands are sorted in alphabetical order, the ones you | ||
probably need to care about are [`start`](#start), [`package`](#package), | ||
[`make`](#make) and [`publish`](#publish). | ||
|
||
### Import | ||
|
||
Maps to `electronForge.import`, will attempt to take an existing Electron app | ||
and make it Forge compatible. Normally this is just created a base forge config | ||
and adding the required dependencies. | ||
|
||
> There are no flags for the Import command | ||
|
||
### Init | ||
|
||
Maps to `electronForge.init`, will initialize a new Forge powered application in | ||
the given directory (defaults to `.`). | ||
|
||
Please note if you want to use a template it must be installed globally before | ||
running the `init` command. | ||
|
||
| Flag | Value | Description | | ||
|------|-------|-------------| | ||
| `--template` | Template Name | Name of the template to use to make this new app| | ||
| `--copy-ci-files` | N/A | Set if you want to copy templated CI files for Travis CI and Appveyor | | ||
|
||
### Install | ||
|
||
Maps to `electronForge.install`, will attempt to install the Electron app | ||
that is published at the given GitHub repository. This command is just a helper | ||
for installing other applications quickly. | ||
|
||
### Lint | ||
|
||
Maps to `electronForge.lint`, will run the `lint` command that your package.json | ||
exposes. If the exit code is 0 no output is shown, otherwise the error output | ||
will be displayed. | ||
|
||
> There are no flags for the Lint command | ||
|
||
### Make | ||
|
||
Maps to `electronForge.make`, will make distributables for your application | ||
based on your forge config and the parameters you pass in. | ||
|
||
| Flag | Value | Description | | ||
|------|-------|-------------| | ||
| `--arch` | Architecture E.g. `x64` | Target architecture to make for | | ||
| `--platform` | Platform E.g. `mas` | Target platform to make for, please note you normally can only target platform X from platform X | | ||
| `--targets` | Comma separated list of maker names | Override your make targets for this run | | ||
| `--skip-package` | N/A | Set if you want to skip the packaging step, useful if you are running sequential makes and want to save time | | ||
|
||
### Package | ||
|
||
Maps to `electronForge.package`, will package your application into a platform | ||
specific format and put the result in a folder. Please note that this does not | ||
make a distributable format, to make proper distributables please use the | ||
[`make`](#make) command. | ||
|
||
| Flag | Value | Description | | ||
|------|-------|-------------| | ||
| `--arch` | Architecture E.g. `x64` | Target architecture to package for | | ||
| `--platform` | Platform E.g. `mas` | Target platform to package for | | ||
|
||
### Publish | ||
|
||
Maps to `electronForge.publish`, will attempt to make the forge application | ||
and then publish it to the publish targets defined in your forge config. | ||
|
||
If you want to publish previously created `make` artifacts you will have to use | ||
the `dry-run` options explained below. | ||
|
||
| Flag | Value | Description | | ||
|------|-------|-------------| | ||
| `--tag` | Version | The version to publish these artifacts as | | ||
| `--target` | Comma separated list of publisher names | Override your publish targets for this run | | ||
| `--dry-run` | N/A | Triggers a publish dry run which saves state and doesn't upload anything | | ||
| `--from-dry-run` | N/A | Attempts to publish artifacts from any dry runs saved on disk | | ||
|
||
### Start | ||
|
||
Maps to `electronForge.start`, will launch the Forge powered application in the | ||
given directory (defaults to `.`). | ||
|
||
| Flag | Value | Description | | ||
|------|-------|-------------| | ||
| `--app-path` | Path to your app from CWD | Override the path to the Electron app to launch (defaults to '.') | | ||
| `--enable-logging` | N/A | Enable advanced logging. This will log internal Electron things | | ||
| `--run-as-node` | N/A | Run the Electron app as a Node.JS script | | ||
| `--inspect-electron` | N/A | Triggers inspect mode on Electron to allow debugging the main process | |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary to be committed to the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required, but helpful for most macOS / *nix users who use nvm (it will auto-select the node version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of odd that it's Node 8 when the minimum version is Node 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend Dev version, not version required for using