Use babel-preset-env in 'init' #47
Conversation
There was a problem hiding this comment.
In general it makes sense, and after much thought technically this isn't breaking so thats good too 👍
In general in this repo we use git-cz for commit messages so that we can generate changelogs and versions automatically. And it looks cooler in the commit history 😆
Simply do npm run commit and fill in the prompts 😄
| envTarget[1].targets.electron = electronPrebuilt.version; | ||
| } | ||
|
|
||
| fs.writeFileSync(path.join(dir, '.compilerc'), JSON.stringify(content, null, 2), 'utf8'); |
There was a problem hiding this comment.
To be async
await fs.writeFile(...)| @@ -50,7 +50,7 @@ describe('forge-config', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe.only('require-search', () => { | |||
There was a problem hiding this comment.
rebasing on master should pull this in
|
Also for some strange reason the CI didn't run, adding another commit should trigger those though 👍 |
anaisbetts
force-pushed
the
preset-env
branch
2 times, most recently
from
6b81148 to
77b14e7
Compare
| await initStarter(dir, program.template ? undefined : program.lintstyle); | ||
| await initNPM(dir, program.template ? undefined : program.lintstyle); |
There was a problem hiding this comment.
Was moving this call intentional?
There was a problem hiding this comment.
Yes, we have to have .compilerc laid down before we can edit it
This PR switches the default Babel preset to use babel-preset-env - this preset adjusts based on the current Electron version which Babel plugins to use. This PR also enables async/await and React by default, since these features are super common and don't have any overhead to enable when not in-use.
More unit tests, fix "Save Fiddle"
This PR switches the default Babel preset to use babel-preset-env - this preset adjusts based on the current Electron version which Babel plugins to use. This PR also enables async/await and React by default, since these features are super common and don't have any overhead to enable if not in-use.