Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-local-electron): add plugin-local-electron #501

Merged
merged 4 commits into from
May 3, 2018

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented May 2, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Used to run a local version of electron instead of the version the electron module downloads

@MarshallOfSound
Copy link
Member Author

Documented on v6.electronforge.io

used to run a local version of electron instead of the version the electron module downloads
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: modulo one question

@@ -9,7 +9,8 @@
"packages/installer/*",
"packages/maker/*",
"packages/publisher/*",
"packages/utils/*"
"packages/utils/*",
"packages/plugin/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin or plugins?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin, it's consistent with installer and maker

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util perhaps 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup will follow up on that

@MarshallOfSound MarshallOfSound merged commit 61b3632 into master May 3, 2018
@MarshallOfSound MarshallOfSound deleted the local-electron-plugin branch May 3, 2018 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants