Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix callback called 2 or more times upon error #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix callback called 2 or more times upon error #97

wants to merge 1 commit into from

Conversation

Jimbly
Copy link

@Jimbly Jimbly commented Dec 20, 2024

Callback was getting called both upon spawn complete as well as upon process error events (in practice was calling the callback twice if the minidump_stackwalk binary didn't exist / was unable to be executed)

@Jimbly Jimbly requested a review from a team as a code owner December 20, 2024 15:16
@Jimbly Jimbly mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jimbly