Skip to content

Commit

Permalink
fix(targets): linux/ia32 official support was removed in Electron 19 (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
malept authored Nov 22, 2022
1 parent 4f9cc44 commit 95d0754
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const buildVersions = {
},
linux: {
arm64: '>= 1.8.0',
ia32: '<19.0.0-beta.1',
mips64el: '^1.8.2-beta.5'
},
mas: {
Expand Down
4 changes: 4 additions & 0 deletions test/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ test('platform=linux and arch=arm64 with a supported official Electron version',
test('platform=linux and arch=arm64 with a supported official Electron version (11.0.0-beta.22)', testMultiTarget({ arch: 'arm64', platform: 'linux', electronVersion: '11.0.0-beta.22' }, 1, 'Package should be generated for linux/arm64'))
test('platform=linux and arch=arm64 with an unsupported official Electron version', testMultiTarget({ arch: 'arm64', platform: 'linux' }, 0, 'Package should not be generated for linux/arm64'))

test('platform=linux and arch=ia32 with a supported official Electron version', testMultiTarget({ arch: 'ia32', platform: 'linux', electronVersion: '10.0.0' }, 1, 'Package should be generated for linux/ia32'))
test('platform=linux and arch=ia32 with an unsupported official Electron version (19.0.0-beta.1)', testMultiTarget({ arch: 'ia32', platform: 'linux', electronVersion: '19.0.0-beta.1' }, 0, 'Package should not be generated for linux/ia32'))
test('platform=linux and arch=ia32 with an unsupported official Electron version', testMultiTarget({ arch: 'ia32', platform: 'linux', electronVersion: '20.0.0' }, 0, 'Package should not be generated for linux/ia32'))

test('platform=linux and arch=mips64el with a supported official Electron version', testMultiTarget({ arch: 'mips64el', platform: 'linux', electronVersion: '1.8.2-beta.5' }, 1, 'Package should be generated for mips64el'))
test('platform=linux and arch=mips64el with an unsupported official Electron version', testMultiTarget({ arch: 'mips64el', platform: 'linux' }, 0, 'Package should not be generated for linux/mips64el'))
test('platform=linux and arch=mips64el with an unsupported official Electron version (2.0.0)', testMultiTarget({ arch: 'mips64el', platform: 'linux', electronVersion: '2.0.0' }, 0, 'Package should not be generated for linux/mips64el'))
Expand Down

0 comments on commit 95d0754

Please sign in to comment.