Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update galactus #1441

Merged
merged 2 commits into from
Nov 4, 2022
Merged

chore: update galactus #1441

merged 2 commits into from
Nov 4, 2022

Conversation

MarshallOfSound
Copy link
Member

This updates galactus to the latest ^1.0.0 release which contains 0 code changes but bumps some dependencies resulting in a new minimum node version of 12 (which is the same as packager currently).

This PR also adds a lockfile because it's unsafe for this repository to not have one 🙃

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1441 (3eba5c9) into main (6abeeca) will increase coverage by 0.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   95.08%   95.58%   +0.50%     
==========================================
  Files          15       15              
  Lines         793      793              
==========================================
+ Hits          754      758       +4     
+ Misses         39       35       -4     
Impacted Files Coverage Δ
src/mac.js 99.41% <0.00%> (+2.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit. 👍 lockfile

@MarshallOfSound MarshallOfSound merged commit 4f9cc44 into main Nov 4, 2022
@MarshallOfSound MarshallOfSound deleted the update-galactus branch November 4, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants