Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: update minimum Node.js version from 14.17.5 to 16.4.0 #1590

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Nov 2, 2023

BREAKING CHANGE: drop support for Node 14

@erikian erikian requested a review from a team as a code owner November 2, 2023 22:58
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1590 (b6610d2) into main (c9b2fa0) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1590   +/-   ##
=======================================
  Coverage   95.73%   95.73%           
=======================================
  Files          15       15           
  Lines         797      797           
=======================================
  Hits          763      763           
  Misses         34       34           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that semantic-release picks up the breaking change and versions correctly, fixup the commit to add "BREAKING CHANGE: foo" in the commit body.

@erikian erikian force-pushed the build/update-nodejs branch from 7696d7f to 56efd3c Compare November 3, 2023 00:55
@erikian erikian force-pushed the build/update-nodejs branch from 56efd3c to 70e0ba4 Compare November 3, 2023 02:20
BREAKING CHANGE: drop support for Node 14
@erikian erikian force-pushed the build/update-nodejs branch from 70e0ba4 to b6610d2 Compare November 3, 2023 20:00
@erikian erikian changed the title build!: update minimum Node.js version from 14.17.5 to 16.0.0 build!: update minimum Node.js version from 14.17.5 to 16.4.0 Nov 3, 2023
@MarshallOfSound MarshallOfSound merged commit 38f4f0a into main Nov 3, 2023
@MarshallOfSound MarshallOfSound deleted the build/update-nodejs branch November 3, 2023 20:11
Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants