Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update TypeDoc #1614

Merged
merged 2 commits into from
Dec 5, 2023
Merged

chore: update TypeDoc #1614

merged 2 commits into from
Dec 5, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Dec 5, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Updated because of the nice dark theme to work with Typescript 5.2:
screenshot

@erikian erikian requested a review from a team as a code owner December 5, 2023 03:54
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3588ea1) 92.03% compared to head (4937f29) 92.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1614   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          16       16           
  Lines         854      854           
  Branches      167      167           
=======================================
  Hits          786      786           
  Misses         51       51           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsanders11
Copy link
Member

Let's also add yarn run docs:build to the CI config so that we catch breakage early next time. 👍

- run: yarn run lint
- run: yarn run coverage
- run: yarn run codecov

@erikian erikian merged commit 9ef0000 into main Dec 5, 2023
5 checks passed
@erikian erikian deleted the chore/update-typedoc branch December 5, 2023 15:36
Copy link

🎉 This PR is included in version 18.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants