Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
With this PR, all of the codebase has been converted to use promises instead of callbacks. Additionally, the code has been largely restructured to use ES6 classes, so it's hopefully easier to follow. This is obviously a really large PR that isn't easy to review (and it was difficult to find any place to split out work), so it may be easier to look at the new code and 🤞 🤞 the tests all pass (they all passed locally and Travis passed when I ran it on the branch).
run-series
has been dropped, but callback support is retained withnodeify
. I don't see dropping support for callbacks inpackager(...)
any time soon.The breaking change is that when you specify multiple targets, they are run "in parallel", due to the usage of
Promise.all
. This fixes #123 to some extent.