Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to node-gyp 7 #379

Closed
wants to merge 1 commit into from

Conversation

adamretter
Copy link

node-gyp 7 has some improvements for building on Catalina and building with Python3 etc.

@adamretter adamretter changed the title Update to node-gyp 7 fix: Update to node-gyp 7 Aug 11, 2020
Signed-off-by: Adam Retter <adam.retter@googlemail.com>
@malept
Copy link
Member

malept commented Aug 11, 2020

This will trigger a semver-major release of electron-rebuild, as node-gyp 7 requires a recent version of Node 10. Please hold off on approving this.

@adamretter
Copy link
Author

@malept Isn't a recent version of Node 10 a good idea? Node10 is already no longer actively developed and will soon be EOL - https://nodejs.org/en/about/releases/

@malept
Copy link
Member

malept commented Aug 11, 2020

Yes, however:

  1. This needs to be explicit. If this PR was merged as-is, it would be released as a patch, not a major version bump.
  2. I have an in-progress branch to update all of the other dependencies that now require Node 10 and I would personally prefer to do all of that together, to avoid multiple version bumps in succession.

@malept
Copy link
Member

malept commented Aug 11, 2020

A workaround for now would be to use yarn resolutions in your projects to resolve any node-gyp dependencies to whatever version you need.

@malept
Copy link
Member

malept commented Aug 11, 2020

I've upgraded node-gyp to version 7 in the version 2 branch, thanks for letting me know about the version bump.

@malept malept closed this Aug 11, 2020
@adamretter
Copy link
Author

@malept Is there any sort of timeframe for a version 2 release of electron-rebuild?

@malept
Copy link
Member

malept commented Aug 11, 2020

Roadmap: #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants