Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run node-gyp rebuild correctly #409

Merged
merged 7 commits into from
Sep 10, 2020

Conversation

malept
Copy link
Member

@malept malept commented Sep 9, 2020

It should have iterated through all of the node-gyp commands since node-gyp rebuild pushes clean, configure, and build commands to the todo list. Also:

  • ensures that the module path is the current working directory when it's running
  • adds a regression test

Fixes #404

@malept malept requested a review from a team September 9, 2020 05:30
@malept malept marked this pull request as draft September 9, 2020 06:17
@malept malept force-pushed the malept/fix/actually-run-node-gyp-rebuild branch from fc76838 to 8026372 Compare September 9, 2020 07:50
@malept malept force-pushed the malept/fix/actually-run-node-gyp-rebuild branch 2 times, most recently from c13a602 to 017187d Compare September 9, 2020 08:39
@malept malept force-pushed the malept/fix/actually-run-node-gyp-rebuild branch from 017187d to 983f622 Compare September 9, 2020 08:55
@malept malept marked this pull request as ready for review September 9, 2020 09:24
@malept
Copy link
Member Author

malept commented Sep 9, 2020

A further complication: node-gyp likes to set the MSVS version (and corresponding environment variable) to 2015, which is very problematic on the CIrcleCI Windows machines. Had to cache the original value when instantiating the Rebuilder class and also restore the environment variable after each call to rebuild() in tests.

@malept
Copy link
Member Author

malept commented Sep 9, 2020

@electron/wg-ecosystem this is ready for review. Sorry for the commit noise earlier, I had to figure out the Windows situation.

One person reports that this PR is working for them: #404 (comment)

@malept malept merged commit 89c013b into master Sep 10, 2020
@malept malept deleted the malept/fix/actually-run-node-gyp-rebuild branch September 10, 2020 16:08
@electron-bot
Copy link

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-gyp not rebuilding correctly
3 participants