Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow EnableEmbeddedAsarIntegrityValidation when multiple asars are present in app #124

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mmaietta
Copy link
Contributor

@mmaietta mmaietta commented Feb 19, 2025

  • When an application uses multiple asars (webapp.asar, anything.asar, etc.), EnableEmbeddedAsarIntegrityValidation fuse breaks the application due to not all asars having integrity generated for them. Fixes: ASAR Integrity assumes a single asar file is present #116
  • Also fixes bug to correctly test makeUniversalApp no asar mode should shim two different app folders, (it was not having an asar integrity generated for the shimmed asar)

Functionality added:

  • Moves all asar integrity generation to after all app assets have been merged/shimmed/copied. This allows other asars that were provided to also be scanned and have asar integrity generated for them.
  • Extracted common Integrity logic to a single file integrity.ts
  • Adds unit test for multi-asar apps

…tyValidation` fuse breaks the application due to not all ASARs having integrity generated for them. Fixes: electron#116
@mmaietta mmaietta marked this pull request as ready for review February 21, 2025 01:20
@mmaietta mmaietta requested a review from a team as a code owner February 21, 2025 01:20
@mmaietta mmaietta force-pushed the multi-asar-integrity branch from e37218f to 61eb5ac Compare February 22, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASAR Integrity assumes a single asar file is present
1 participant