Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: broken links in non-english pages apps page language dropdown. #446

Open
ghs-vsc-acc opened this issue Sep 13, 2023 · 6 comments
Open
Labels
area:i18n Related to website internationalization 🪲 bug Something isn't working

Comments

@ghs-vsc-acc
Copy link

When on the 'apps' section of the electron page (https://electronjs.org/apps/), under the language dropdown menu when under the non-english version of the page (for example when in https://electronjs.org/pt/apps, the dropdowns are incorrect.

  1. when clicking a language on the dropdown it redirects you to a route with an error in the path instead of a single slash separating its 2 (expected result: https://electronjs.org/pt/apps/, actual result: https://electronjs.org/pt//apps)
  2. when clicking the english selection under the language drop-down menu, it simply directs you to a wrong path, that path being https://apps instead of https://electronjs.org/apps
@erickzhao erickzhao added 🪲 bug Something isn't working area:i18n Related to website internationalization labels Sep 13, 2023
@bEluga0000
Copy link

I got what the issue is but i not am getting how the li tag accepting the links can anyone help.

@ifhammohamed
Copy link

[bug] : #446 in this bug,
I got understood the issue, and I'm currently working on it. Do I move further ?

When on the 'apps' section of the electron page (https://electronjs.org/apps/), under the language dropdown menu when under the non-english version of the page (for example when in https://electronjs.org/pt/apps, the dropdowns are incorrect.

  1. when clicking a language on the dropdown it redirects you to a route with an error in the path instead of a single slash separating its 2 (expected result: https://electronjs.org/pt/apps/, actual result: https://electronjs.org/pt//apps)
  2. when clicking the english selection under the language drop-down menu, it simply directs you to a wrong path, that path being https://apps instead of https://electronjs.org/apps

@ShravaniAK

This comment has been minimized.

@viskar07
Copy link

Hi there,
I'm interested in contributing to this issue! Could someone please provide me with permission to get started?

@pramodgoud7

This comment has been minimized.

@VerteDinde
Copy link
Member

Hey folks, please don't write "assign me" or other variations, GitHub will likely flag your account as spam if you do this, especially if you do it in multiple issues. If you'd like to tackle this problem, please just submit a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Related to website internationalization 🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants