Compte épargne : répare une erreur en début de cycle #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the title
raphodn
commented
Sep 13, 2023
| @@ -304,8 +304,8 @@ private function createCycleBeginningLog(Membership $member, \DateTime $date) | |||
|
|
|||
| $this->em->refresh($member); // added to prevent from returning cached (old) data | |||
|
|
|||
| $member_counter_date = $member->getShiftTimeCount($date); | |||
| $extra_counter_time = $member_counter_date - ($this->due_duration_by_cycle + $this->max_time_at_end_of_shift); | |||
| $member_counter_now = $member->getShiftTimeCount(); | |||
There was a problem hiding this comment.
la ligne la plus importante de cette PR :)
There was a problem hiding this comment.
Hmm, y'a pas un effet de bord sur d'autres coop ici ?
Je m'explique : quand tu désactives l'option de valider les créneaux via la badgeuse, ils sont automatiquement validés à la date future du créneau. Si tu prends un créneau sur le cycle N+1, il ne faut pas qu'à la fin du cycle N, il soit pris en compte dans le calcul.
There was a problem hiding this comment.
Je vois... Peut-être remettre le paramètre $date du coup, mais on rajoutant 1 minute par exemple pour être sûr d'avoir le time count à jour ?
raphodn
commented
Sep 13, 2023
raphodn
commented
Sep 13, 2023
raphodn
force-pushed
the
raphodn/time-log-saving-end-fix
branch
from
22b5b16
to
c019338
Compare
petitalb
approved these changes
Sep 21, 2023
raphodn
force-pushed
the
raphodn/time-log-saving-end-fix
branch
from
bf66f35
to
5b06140
Compare
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
…#990) * OnCycleEnd: fix member saving time count calculation * Fix calculation with extra_counter_time * Modify a bit date to get full shiftTimeCount * Small wording change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Lors du début de cycle,
createCycleBeginningLogest appelé.Mais lors de notre calcul du compteur temps du membre, on passait un paramètre $date, ce qui avait pour conséquence de (parfois ?) ignorer le plus récent log de temps (celui de début de cycle).