Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent crossfade on initial render #42

Closed
wants to merge 1 commit into from
Closed

fix: prevent crossfade on initial render #42

wants to merge 1 commit into from

Conversation

ncblair
Copy link
Contributor

@ncblair ncblair commented Apr 3, 2024

set currentGain to 1 if currentRoots is empty

@nick-thompson
Copy link
Contributor

Perfect thanks @ncblair! It looks like this same change is included in the other open PR #41– should I be looking at one or the other? I'm happy to take this as-is but it looks like it'd introduce merge conflicts on the other

@ncblair
Copy link
Contributor Author

ncblair commented Apr 15, 2024

We can just use the other PR! happy to close this one

@nick-thompson
Copy link
Contributor

Ok great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncblair @nick-thompson