Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tokens and remove colors.textPlaceholder #103

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Update tokens and remove colors.textPlaceholder #103

merged 2 commits into from
Nov 18, 2024

Conversation

jmartinesp
Copy link
Member

What the title says.

@jmartinesp jmartinesp requested a review from bmarty November 15, 2024 08:11
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.67949% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (1afc0a0) to head (48be5b9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...android/compound/tokens/generated/CompoundIcons.kt 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   84.99%   84.59%   -0.40%     
==========================================
  Files          23       23              
  Lines        2752     2779      +27     
  Branches      232      242      +10     
==========================================
+ Hits         2339     2351      +12     
- Misses        198      211      +13     
- Partials      215      217       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

...und/src/main/kotlin/io/element/android/compound/tokens/generated/internal/DarkColorTokens.kt
val colorAlphaPink1100 = Color(0xfffe86a4)
val colorAlphaPink1200 = Color(0xffffadc0)
val colorAlphaPink1300 = Color(0xffffd1db)
val colorAlphaPink1400 = Color(0xffffebef)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shame that this cannot be diff easily. We should probably sort the val alphabetically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's something we can add in https://github.com/element-hq/compound-design-tokens for that, but I somehow doubt it'll be that easy.

@jmartinesp jmartinesp merged commit fa64ad3 into main Nov 18, 2024
5 checks passed
@jmartinesp jmartinesp deleted the misc/update-tokens-remove-text-placeholder branch November 18, 2024 12:11
@jmartinesp
Copy link
Member Author

jmartinesp commented Nov 18, 2024 •
edited
Loading

Actually, it wasn't that hard to sort the tokens alphabetically: element-hq/compound-design-tokens#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartinesp @bmarty