Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import new tokens, sorted with alphabetical ordering #107

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Nov 19, 2024

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 98.30221% with 20 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (125dd54) to head (a0a006d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...android/compound/tokens/generated/CompoundIcons.kt 50.00% 10 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   84.59%   84.11%   -0.48%     
==========================================
  Files          23       23              
  Lines        2779     2821      +42     
  Branches      242      252      +10     
==========================================
+ Hits         2351     2373      +22     
- Misses        211      221      +10     
- Partials      217      227      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. New icons does not need to be mirrored AFAICT.

@jmartinesp jmartinesp merged commit 4e5e67f into main Nov 19, 2024
5 checks passed
@jmartinesp jmartinesp deleted the update-tokens-in-alphabetical-order branch November 19, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants