Tooltip: handle non-interactive tooltip triggers #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
requested review from
dbkr and
robintown
and removed request for
a team
Deploying with
|
| Latest commit: |
9f2f6d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14a2c810.compound-web.pages.dev |
| Branch Preview URL: | https://kerry-280-tooltip-delay.compound-web.pages.dev |
kerryarchibald
changed the title
t3chguy
reviewed
Nov 20, 2023
robintown
reviewed
Nov 20, 2023
added 2 commits
November 29, 2023 13:13
robintown
approved these changes
Nov 29, 2023
Co-authored-by: Robin <robin@robin.town>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/compound#280
For element-hq/compound#248
Radix tooltip needs trigger elements to receive pointer events to hide/show tooltip correctly on mouseover
Trigger elements must also receive focus to open on focus.
This PR adds the optional property
isTriggerInteractive, and wraps uninteractive triggers with a focusable span, as recommended by radix. The most common pattern for tooltips is use on interactive elements (icon buttons) soisTriggerInteractivedefaults to true.Screen.Recording.2023-11-20.at.15.18.48.mov
Also sets delay according to trigger interactivity, as described in element-hq/compound#280