Merge pull request #3656 from SpiritCroc/broken_downloads

Avoid incomplete downloads in cache
element-hq · Jul 19, 2021 · 2e64f89 · 2e64f89
2 parents f517691 + 512e1b3
commit 2e64f89
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/changelog.d/3656.bugfix b/changelog.d/3656.bugfix
@@ -0,0 +1 @@
+Avoid incomplete downloads in cache
diff --git a/...x-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/DefaultFileService.kt b/...x-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/DefaultFileService.kt
@@ -131,8 +131,14 @@ internal class DefaultFileService @Inject constructor(
                     Timber.v("Response size ${response.body?.contentLength()} - Stream available: ${!source.exhausted()}")
 
                     // Write the file to cache (encrypted version if the file is encrypted)
-                    writeToFile(source.inputStream(), cachedFiles.file)
+                    // Write to a tmp file first, so if we abort before done, we don't have a broken cached file
+                    val tmpFile = File(cachedFiles.file.parentFile, "${cachedFiles.file.name}.tmp")
+                    if (tmpFile.exists()) {
+                        Timber.v("## FileService: discard aborted tmp file ${tmpFile.path}")
+                    }
+                    writeToFile(source.inputStream(), tmpFile)
                     response.close()
+                    tmpFile.renameTo(cachedFiles.file)
                 } else {
                     Timber.v("## FileService: cache hit for $url")
                 }
@@ -145,15 +151,21 @@ internal class DefaultFileService @Inject constructor(
                     Timber.v("## FileService: decrypt file")
                     // Ensure the parent folder exists
                     cachedFiles.decryptedFile.parentFile?.mkdirs()
+                    // Write to a tmp file first, so if we abort before done, we don't have a broken cached file
+                    val tmpFile = File(cachedFiles.decryptedFile.parentFile, "${cachedFiles.decryptedFile.name}.tmp")
+                    if (tmpFile.exists()) {
+                        Timber.v("## FileService: discard aborted tmp file ${tmpFile.path}")
+                    }
                     val decryptSuccess = cachedFiles.file.inputStream().use { inputStream ->
-                        cachedFiles.decryptedFile.outputStream().buffered().use { outputStream ->
+                        tmpFile.outputStream().buffered().use { outputStream ->
                             MXEncryptedAttachments.decryptAttachment(
                                     inputStream,
                                     elementToDecrypt,
                                     outputStream
                             )
                         }
                     }
+                    tmpFile.renameTo(cachedFiles.decryptedFile)
                     if (!decryptSuccess) {
                         throw IllegalStateException("Decryption error")
                     }