Merge pull request #4729 from vector-im/feature/adm/avoid-leaking-win…

…dow-when-showing-loading Avoid leaking Activity Window when showing loading dialog
element-hq · Dec 16, 2021 · 3b35be5 · 3b35be5
2 parents addeec0 + eb9c46b
commit 3b35be5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/changelog.d/4713.misc b/changelog.d/4713.misc
@@ -0,0 +1 @@
+Avoids leaking the activity windows when loading dialogs are displaying
diff --git a/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt b/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt
@@ -151,6 +151,7 @@ abstract class VectorBaseFragment<VB : ViewBinding> : Fragment(), MavericksView
     override fun onDestroyView() {
         Timber.i("onDestroyView Fragment ${javaClass.simpleName}")
         _binding = null
+        dismissLoadingDialog()
         super.onDestroyView()
     }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Avoids leaking the activity windows when loading dialogs are displaying