Merge pull request #3538 from vector-im/feature/fga/fix_signout

Fix crash on signout: release session at the end of clean up
element-hq · Jun 21, 2021 · 4340180 · 4340180
2 parents b30c27b + d8327a5
commit 4340180
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/changelog.d/3538.bugfix b/changelog.d/3538.bugfix
@@ -0,0 +1 @@
+Fix crash on signout: release session at the end of clean up.
diff --git a/...k-android/src/main/java/org/matrix/android/sdk/internal/session/cleanup/CleanupSession.kt b/...k-android/src/main/java/org/matrix/android/sdk/internal/session/cleanup/CleanupSession.kt
@@ -51,15 +51,12 @@ internal class CleanupSession @Inject constructor(
         @UserMd5 private val userMd5: String
 ) {
     suspend fun handle() {
-        Timber.d("Cleanup: release session...")
-        sessionManager.releaseSession(sessionId)
+        Timber.d("Cleanup: delete session params...")
+        sessionParamsStore.delete(sessionId)
 
         Timber.d("Cleanup: cancel pending works...")
         workManagerProvider.cancelAllWorks()
 
-        Timber.d("Cleanup: delete session params...")
-        sessionParamsStore.delete(sessionId)
-
         Timber.d("Cleanup: clear session data...")
         clearSessionDataTask.execute(Unit)
 
@@ -74,6 +71,9 @@ internal class CleanupSession @Inject constructor(
         realmKeysUtils.clear(SessionModule.getKeyAlias(userMd5))
         realmKeysUtils.clear(CryptoModule.getKeyAlias(userMd5))
 
+        Timber.d("Cleanup: release session...")
+        sessionManager.releaseSession(sessionId)
+
         // Sanity check
         if (BuildConfig.DEBUG) {
             Realm.getGlobalInstanceCount(realmSessionConfiguration)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix crash on signout: release session at the end of clean up.