It is not possiable to changing user avatar

[375573088]

Steps to reproduce

It is not possiable to changing user avatar


cut and uploading photo

Outcome

final Exception：android.os.NetworkOnMainThreadException

Your phone model

18208727060

Operating system version

Android 31

Application version and app store

No response

Homeserver

https://im.ynzzpt.cn/

Will you send logs?

Yes

[YamatoRyou]

Same as me.
#4730

[ouchadam]

I'm unable to reproduce this issue (matrix.org and a private server) using the latest from develop,

which version of Element Android is this / have you made any modifications?

[375573088]

Changes in Element v1.3.9 (2021-12-01)

[375573088]

And i did't have made any modifications.
That is my virtual machine device：

[ouchadam]

interesting 🤔

• are you able to confirm if the exception is thrown by...

val response = fileUploader.uploadFromUri(...)

https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/profile/DefaultProfileService.kt#L72

or

setAvatarUrlTask.execute(...)

https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/profile/DefaultProfileService.kt#L73

• and are you able to check if matrix.org works?

[375573088]

This is try catch code，and execute the code Exception：android.os.NetworkOnMainThreadException

  override suspend fun updateAvatar(userId: String, newAvatarUri: Uri, fileName: String) {
        val logger = FormattedJsonHttpLogger()
        withContext(coroutineDispatchers.main) {
           try{
               val response = fileUploader.uploadFromUri(newAvatarUri, fileName, MimeTypes.Jpeg)
               setAvatarUrlTask.execute(SetAvatarUrlTask.Params(userId = userId, newAvatarUrl = response.contentUri))
               userStore.updateAvatar(userId, response.contentUri)
           }
           catch (e :Exception){
               logger.log("updateAvatar------>"+ e.message)  // android.os.NetworkOnMainThreadException
           }
        }
    }

[ouchadam]

what happens if we only execute the file uploading?

  override suspend fun updateAvatar(userId: String, newAvatarUri: Uri, fileName: String) {
        val logger = FormattedJsonHttpLogger()
        withContext(coroutineDispatchers.main) {
           try{
               fileUploader.uploadFromUri(newAvatarUri, fileName, MimeTypes.Jpeg)
               //setAvatarUrlTask.execute(SetAvatarUrlTask.Params(userId = userId, newAvatarUrl = response.contentUri))
               //userStore.updateAvatar(userId, response.contentUri)
           }
           catch (e :Exception){
               logger.log("updateAvatar------>"+ e.message)  // android.os.NetworkOnMainThreadException
           }
        }
    }

if we still get the NetworkOnMainThreadException then it proves the error is within fileUploader.uploadFromUri, if there is no error then we can infer that setAvatarUrlTask.execute is the problem

[375573088]

The way just only execute this code and exception：

fileUploader.uploadFromUri(newAvatarUri, fileName, MimeTypes.Jpeg)

however it is not step into below code：

setAvatarUrlTask.execute

[ouchadam]

I'm really confused by this issue, the only way I've been able to reproduce the NetworkOnMainThreadException in the uploadFromUri flow is by replacing okHttpClient.newCall(request).awaitResponse() with okHttpClient.newCall(request).execute()

https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/content/FileUploader.kt#L144

@375573088 does changing the dispatcher to .io fix the exception?

- withContext(coroutineDispatchers.main) {
+ withContext(coroutineDispatchers.io) {

https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/profile/DefaultProfileService.kt#L71

[375573088]

Very nice ，Thanks for you. Use coroutineDispatchers.io it is dit fixed the exception and setAvatar successed。
i guess coroutineDispatchers.main it's can not dispatch my process into asynchronous process。

 withContext(coroutineDispatchers.io)

Now ， Wish you a merry Christmas in advance. 3Q

[ouchadam]

💯 great to hear! I'll raise a PR with the change

thanks for your help with debugging

[375573088]

💯 great to hear! I'll raise a PR with the change

thanks for your help with debugging

No problem，hahaha~

[bmarty]

Fix included in EA 1.3.13