Unable to change avatar due to NetworkOnMainThread
#4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes some devices/OS's from attempting to run okhttp on the main thread
ouchadam
commented
Dec 21, 2021
| @@ -68,7 +68,7 @@ internal class DefaultProfileService @Inject constructor(private val taskExecuto | |||
| } | |||
|
|
|||
| override suspend fun updateAvatar(userId: String, newAvatarUri: Uri, fileName: String) { | |||
| withContext(coroutineDispatchers.main) { | |||
| withContext(coroutineDispatchers.io) { | |||
There was a problem hiding this comment.
Its something we already had fixed, not sure why its back. But fileUploader should already dispatch on a background thread, its weird
There was a problem hiding this comment.
yeah it's very strange, I checked the okhttp thread pool/interceptors as well, couldn't find any cases where the main thread was being used, unless on some devices the internal okhttp thread uses the main thread/looper for some reason 🤔
There was a problem hiding this comment.
This is also something which has been fixed by some fork on their side FWIW.
bmarty
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4767 Unable to change avatar
We had a report of
NetworkOnMainThreadwhilst changing avatar, I've been unable to reproduce the issue but did notice we have an unnecessary main thread dispatcher being used (looks like it was introduced as part of the suspend migration).maindispatcher toio, the user has also confirmed this fixed their issue