No animation -> no chat effect #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will speed up the sanity test
bmarty
added
the
Z-NextRelease
bmarty
requested review from
a team,
onurays and
fedrunov
and removed request for
a team
bmarty
commented
May 5, 2022
| @@ -218,7 +218,7 @@ class PopupAlertManager @Inject constructor( | |||
| if (!alert.isLight) { | |||
| clearLightStatusBar() | |||
| } | |||
| val noAnimation = !animate || isAnimationDisabled(activity) | |||
| val noAnimation = !(animate && activity.isAnimationEnabled()) | |||
There was a problem hiding this comment.
I've read it several times, but please double check this change :)
There was a problem hiding this comment.
took me some time to proceed, but looks correct
fedrunov
approved these changes
May 5, 2022
| @@ -218,7 +218,7 @@ class PopupAlertManager @Inject constructor( | |||
| if (!alert.isLight) { | |||
| clearLightStatusBar() | |||
| } | |||
| val noAnimation = !animate || isAnimationDisabled(activity) | |||
| val noAnimation = !(animate && activity.isAnimationEnabled()) | |||
There was a problem hiding this comment.
took me some time to proceed, but looks correct
bmarty
removed
the
Z-NextRelease
|
(the label next release was added by mistake) |
Matrix SDKIntegration Tests Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
If the user does not want to see animation, no chat effect will be performed. Also no account creation celebration will e displayed.
Motivation and context
It will speed up the UI test, which have animation disabled.
It can also be useful to user with health condition (see #5557)
I tried to update the speed for Konfetti regarding the animation scale, but I think it has to be handled by the third party library. Same for the snowfall.
Screenshots / GIFs
Tests
Tested devices
Checklist