Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rich text editor breaks back button #7420

Closed
lub opened this issue Oct 20, 2022 · 2 comments
Closed

rich text editor breaks back button #7420

lub opened this issue Oct 20, 2022 · 2 comments
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@lub
Copy link

lub commented Oct 20, 2022

Steps to reproduce

  1. open a room room
  2. tap on the rich text editor area (keyboard pops up, like it should)
  3. press android back button (not the arrow within element itself) (keyboard disappears, like it should)
  4. press android back button again

Outcome

What did you expect?

To get back to the previous view, like it works without enabled richt text editor or if I don't tap on the rich text editor.

What happened instead?

Nothing happens. It just stays in the timeline view.

Your phone model

Oneplus A5010

Operating system version

Android 12/LienageOS 19-20221018-nightly-dumpling

Application version and app store

1.5.6-dev [212772242] (F-b12134) develop

Homeserver

imninja.net

Will you send logs?

Yes

Are you willing to provide a PR?

No
@lub lub added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 20, 2022
@jmartinesp jmartinesp added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist labels Oct 21, 2022
@jmartinesp
Copy link
Member

It seems like the hardware keyboard listener that we use to intercept key presses actually intercepts the back key too by accident.

@jmartinesp jmartinesp added the A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor label Oct 21, 2022
@jmartinesp jmartinesp mentioned this issue Oct 24, 2022
Open
@wo80 wo80 mentioned this issue Oct 26, 2022
Closed
@jmartinesp jmartinesp mentioned this issue Nov 8, 2022
Closed
@jmartinesp
Copy link
Member

This should have been fixed by #7572.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmartinesp @lub @langleyd