Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if migration disabled notif #1821

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Conversation

BillCarsonFr
Copy link
Member

Fixes #1723

Root cause not found yet; so has a work around a check is performed (once) to see if notifications are disabled for this session and prompt user to review settings if needed.

image

review

@BillCarsonFr BillCarsonFr requested a review from ganfra July 27, 2020 14:58
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ok!

@ganfra
Copy link
Member

ganfra commented Jul 28, 2020

Just fix code quality before merging

@BillCarsonFr BillCarsonFr force-pushed the feature/notification_off_alert branch from 7ea7fa7 to 5ab1ed2 Compare July 28, 2020 14:55
@BillCarsonFr BillCarsonFr force-pushed the feature/notification_off_alert branch from 5ab1ed2 to e619217 Compare July 28, 2020 14:57
@BillCarsonFr BillCarsonFr merged commit dde9cdd into develop Jul 28, 2020
@BillCarsonFr BillCarsonFr deleted the feature/notification_off_alert branch July 28, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from old client does not enable notifications
2 participants