Navigation | New Home tab to priorize all unread - BLOCKED #4010

BillCarsonFr · 2021-09-14T08:04:32Z

App Navigation modification.

This PR introduces a new Home Tab, in this tab you will find all important things you need to read first in a less busy and more compact layout so you can see more at once (one line per room with no last message preview or timestamp) .

It is combining rooms and people into one list, in order to stop people having to change tabs to check on unread rooms/people.

The Home tab contains in order

Invites if any
Your Favorites for quick access
DMs with notifications
Rooms with notifications
Other Rooms sorted by unread first
Other Dms
Suggested rooms of space if any

The existing DM tabs and Room Tabs are modified a bit, they won't show favorite or invites anymore as they will be on Home already. They will continue to display rooms in last activity order with a more detailed view (last message, typing indicator, timestamp, bigger avatar).

Check Legacy community organization of sections and tabs
Probably need to update empty state of home
Check new user experience, and space joining flow

jwsp1 · 2021-09-14T14:31:35Z

General thought: I don't see the need to separate rooms into categories like Favorites, Unread DM, Unread Rooms, DM, Rooms, and Low Priority. It just wastes valuable space which could be used to show a preview of the latest message.

If this is supposed to fix #650, then it is not quite what people wanted.
The most simple style for most users would be to remove all tabs and show rooms in this order:

Favorites (always pinned to top),
then DM/Rooms ordered by time of latest message,
then Low Priority (always pinned to bottom).

github-actions · 2021-09-16T14:13:41Z

Unit Test Results

  44 files ±0   44 suites ±0 45s ⏱️ -5s
  87 tests ±0   87 ✔️ ±0 0 💤 ±0 0 ❌ ±0
228 runs ±0 228 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 70d0e5f. ± Comparison against base commit 9661fa0.

♻️ This comment has been updated with latest results.

BillCarsonFr · 2021-09-16T14:48:45Z

Following feedbacks from this (and related issues), I added a new Preference that allows users to select their preferred layout

Pro Layout will have 3 tabs, Home/Dms/Rooms .
Home will put every rooms/dms with notification on top, and will replace the previous optional 3rd tab (notifications only).
Home will have Invites / Favorites and they won't be repeated in other tabs

Simple layout will have no tabs, so all your rooms & Dms in one list ordered by activity. Invite & Fav on top

bmarty

First remarks:

This PR has to be rebased.
Also please ensure that the sanity test is still passing (it will need some update)
I will do a full review later

bmarty

Thanks for doing this, I'm sure it will be really appreciated.
Please see my comments

bmarty · 2021-10-05T10:15:24Z

vector/src/main/java/im/vector/app/features/home/HomeDetailViewModel.kt

+    private fun handleViewResumed() {
+        // Good place to check for layout mode
+        setState {
+            copy(layoutMode = vectorPreferences.getLayoutMode())


setState only if the value is not the same? It's maybe done internally by MvRx, not sure.

selectSubscribe is doing distinct until changed

bmarty · 2021-10-05T10:20:17Z

vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt

+    // Layout
+
+    fun getLayoutMode(): LayoutMode {
+        return defaultPrefs.getString(SETTINGS_LAYOUT_MODE, LayoutMode.PRODUCTIVITY.name).let {


Default is PRODUCTIVITY? I would say SIMPLE would be better, or maybe reuse the setting SETTINGS_LABS_UNREAD_NOTIFICATIONS_AS_TAB, if true -> PRODUCTIVITY

Yes it was decided to use productivity as default to not disturb too much current experience and user flows.
It's a good idea to check for SETTINGS_LABS_UNREAD_NOTIFICATIONS_AS_TAB as a discriminator.
I also wonder if SETTINGS_LABS_UNREAD_NOTIFICATIONS_AS_TAB user will be satisifed by the new home, maybe they would want the new home to only show unreads?

Ok, but new accounts should definitely see the SIMPLE layout then. Do you agree?

I changed to do as you proposed (SETTINGS_LABS_UNREAD_NOTIFICATIONS_AS_TAB, if true -> PRODUCTIVITY)

bmarty · 2021-10-05T10:23:12Z

vector/src/main/res/drawable/ic_pro_layout.xml

@@ -0,0 +1,84 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


rename the two drawable vectors to ensure they have a common prefix: ic_layout_pro and ic_layout_simple. Also those are not really icon, so maybe setting_layout_pro and setting_layout_simple would be better names

bmarty · 2021-10-05T10:23:54Z

vector/src/main/res/drawable/ic_simple_layout.xml

+  <path
+      android:pathData="M16,17m-8,0a8,8 0,1 1,16 0a8,8 0,1 1,-16 0"
+      android:strokeWidth="1"
+      android:fillColor="#C1C6CD"


does it render well in dark theme?

In simple layout, there have not any Direct Messages button. I think it would be easier for searching people if there have a Direct Messages button.

does it render well in dark theme?

Yes

In simple layout, there have not any Direct Messages button.

There is, when you tap the FAB button you have a choice between new DM or new room

Yes

Sorry, but is it really what we want in dark theme? white bg like that?

EDIT: this is related to the same drawable, sorry

bmarty · 2021-10-05T10:24:41Z

vector/src/main/res/layout/preference_app_choose_layout.xml

+        <!--                android:drawableEnd="@drawable/ic_pro_layout"-->
+        <!--                android:text="@string/settings_home_layout_pro"-->
+        <!--                tools:checked="false" />-->
+


vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt

bmarty · 2021-10-13T13:24:25Z

library/ui-styles/src/main/res/values/attrs_drawables.xml

+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+
+    <!-- room message colors -->


update this comment?

bmarty

LGTM, thanks!
As discussed, will be merged today so that we can get some feedback before the next release.

kojid0 · 2021-10-22T14:47:53Z

LGTM, thanks! As discussed, will be merged today so that we can get some feedback before the next release.

Is it already in the debug build? Cannot find it / give feedback

bmarty · 2021-10-22T14:56:47Z

LGTM, thanks! As discussed, will be merged today so that we can get some feedback before the next release.

Is it already in the debug build? Cannot find it / give feedback

The merging of this PR has been delayed, the changes it brings require more internal discussions

AnisTaluqdar · 2021-12-07T07:53:08Z

Still, waiting for it. 🥺 Will it be available this year?

Flam3z · 2021-12-08T11:05:22Z

We can only hope and be patient :)

kojid0 · 2021-12-10T10:44:36Z

The merging of this PR has been delayed, the changes it brings require more internal discussions

I understand that the Design Team might wand to unify the look&feel between Android&iOS, but this PR is really necessary for simplicity.
Currently, you will miss reading messages if you forget to frequently look in both tabs. I have two users where I see that they respond in rooms but not in DMs because they don't check both places.
Please merge this (as it's a working solution for now) and get back to it later if necessary.

bmarty · 2022-02-28T13:14:57Z

Let's remove this PR, we will iterate with IA later.

kojid0 · 2022-05-03T08:19:53Z

Can you please link the subsequent issue / PR?
Still waiting for this... Many of my friends miss new messages because they don't look in both tabs.

jwsp1 mentioned this pull request Sep 14, 2021

Display conversations all in one list #650

Open

BillCarsonFr force-pushed the feature/bca/home_navigation branch from 0dbcce6 to cf9a23c Compare September 16, 2021 13:50

BillCarsonFr force-pushed the feature/bca/home_navigation branch 2 times, most recently from 30c763e to 0316a15 Compare September 22, 2021 07:01

BillCarsonFr force-pushed the feature/bca/home_navigation branch from d900132 to 914a8b0 Compare September 29, 2021 15:12

bmarty requested changes Sep 29, 2021

View reviewed changes

bmarty mentioned this pull request Oct 4, 2021

Newly arriving dm invite is briefly sorted into room before immediately disappearing to peoples tab #4148

Open

BillCarsonFr force-pushed the feature/bca/home_navigation branch from a0a1ee1 to 9fb4fcc Compare October 4, 2021 15:59

bmarty reviewed Oct 5, 2021

View reviewed changes

BillCarsonFr added 12 commits October 13, 2021 11:21

Navigation | New Home tab to priorize all unread

0d8a190

Add support for simple vs pro layout

e21c25c

Quick legacy community layout support

a0c3541

Show Fab in all in one mode

c6931d7

Fix wrong highlight

80cf904

Fix low priority section in home and bad notification highlight

bf41085

Quick design update

250c7df

Update layout mode names

6423459

Add layout mode test

37486b3

cleanup

7498c22

Fix rebase

83229fa

ktlint

fe9b4ef

BillCarsonFr force-pushed the feature/bca/home_navigation branch from 9fb4fcc to fe9b4ef Compare October 13, 2021 09:21

Use old labNotif tab to decide on best default layout mode

8b61c28

bmarty reviewed Oct 13, 2021

View reviewed changes

vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt Outdated Show resolved Hide resolved

BillCarsonFr added 2 commits October 13, 2021 12:21

Change visibility of legacy pref

defd423

FIx empty state + proper dark mode

f700330

bmarty reviewed Oct 13, 2021

View reviewed changes

bmarty approved these changes Oct 13, 2021

View reviewed changes

bmarty added 2 commits October 13, 2021 15:37

Clean up

3b90446

Code quality

70d0e5f

kojid0 mentioned this pull request Nov 23, 2021

Adjust Home Screen App Layout to make it look more like Element Android element-hq/element-ios#5183

Open

bmarty changed the title ~~Navigation | New Home tab to priorize all unread~~ Navigation | New Home tab to priorize all unread - BLOCKED Jan 6, 2022

kojid0 mentioned this pull request Jan 7, 2022

First Start: Offer a Tour element-hq/element-meta#90

Closed

bmarty closed this Feb 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Navigation | New Home tab to priorize all unread - BLOCKED #4010

Navigation | New Home tab to priorize all unread - BLOCKED #4010

BillCarsonFr commented Sep 14, 2021 •

edited

Loading

jwsp1 commented Sep 14, 2021

github-actions bot commented Sep 16, 2021 •

edited

Loading

BillCarsonFr commented Sep 16, 2021 •

edited

Loading

bmarty left a comment

bmarty left a comment

bmarty Oct 5, 2021

BillCarsonFr Oct 13, 2021

bmarty Oct 5, 2021

BillCarsonFr Oct 13, 2021

bmarty Oct 13, 2021

BillCarsonFr Oct 13, 2021

bmarty Oct 5, 2021

BillCarsonFr Oct 13, 2021

bmarty Oct 5, 2021

AnisTaluqdar Oct 11, 2021

BillCarsonFr Oct 13, 2021

bmarty Oct 13, 2021 •

edited

Loading

bmarty Oct 5, 2021

BillCarsonFr Oct 13, 2021

bmarty Oct 13, 2021

bmarty left a comment

kojid0 commented Oct 22, 2021

bmarty commented Oct 22, 2021

AnisTaluqdar commented Dec 7, 2021 •

edited

Loading

Flam3z commented Dec 8, 2021

kojid0 commented Dec 10, 2021

bmarty commented Feb 28, 2022

kojid0 commented May 3, 2022

		@@ -0,0 +1,84 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android"

Navigation | New Home tab to priorize all unread - BLOCKED #4010

Navigation | New Home tab to priorize all unread - BLOCKED #4010

Conversation

BillCarsonFr commented Sep 14, 2021 • edited Loading

jwsp1 commented Sep 14, 2021

github-actions bot commented Sep 16, 2021 • edited Loading

Unit Test Results

BillCarsonFr commented Sep 16, 2021 • edited Loading

bmarty left a comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty Oct 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

kojid0 commented Oct 22, 2021

bmarty commented Oct 22, 2021

AnisTaluqdar commented Dec 7, 2021 • edited Loading

Flam3z commented Dec 8, 2021

kojid0 commented Dec 10, 2021

bmarty commented Feb 28, 2022

kojid0 commented May 3, 2022

BillCarsonFr commented Sep 14, 2021 •

edited

Loading

github-actions bot commented Sep 16, 2021 •

edited

Loading

BillCarsonFr commented Sep 16, 2021 •

edited

Loading

bmarty Oct 13, 2021 •

edited

Loading

AnisTaluqdar commented Dec 7, 2021 •

edited

Loading