Feature/fga/mavericks 2 #4190
Merged
Feature/fga/mavericks 2 #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
September 30, 2021 19:52
… entirely migrating to flow
…ier when entirely migrating to flow" This reverts commit d9b02a2.
ganfra
commented
Oct 8, 2021
| abstract class VectorViewModel<S : MvRxState, VA : VectorViewModelAction, VE : VectorViewEvents>(initialState: S) : | ||
| BaseMvRxViewModel<S>(initialState, false) { | ||
| abstract class VectorViewModel<S : MavericksState, VA : VectorViewModelAction, VE : VectorViewEvents>(initialState: S) : | ||
| BaseMvRxViewModel<S>(initialState) { |
There was a problem hiding this comment.
Still using BaseMvRxViewModel as we have some Rx. In the end it will be changed to MavericksViewModel.
There was a problem hiding this comment.
OK, can you create an issue to track the future change please?
bmarty
reviewed
Oct 11, 2021
matrix-sdk-android-flow/src/main/java/org/matrix/android/sdk/flow/FlowExt.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android-flow/src/main/java/org/matrix/android/sdk/flow/FlowSession.kt
Outdated
Show resolved
Hide resolved
| @@ -137,7 +138,7 @@ class VectorApplication : | |||
| } | |||
| logInfo() | |||
| LazyThreeTen.init(this) | |||
|
|
|||
| Mavericks.initialize(debugMode = false) | |||
There was a problem hiding this comment.
use BuildConfig.DEBUG ? (not checked the effect)
There was a problem hiding this comment.
We can't as it will double check setState to be idempotent, but we have some "tricks" which breaks this
| @@ -88,7 +89,7 @@ import timber.log.Timber | |||
| import java.util.concurrent.TimeUnit | |||
| import kotlin.system.measureTimeMillis | |||
|
|
|||
| abstract class VectorBaseActivity<VB : ViewBinding> : AppCompatActivity(), HasScreenInjector { | |||
| abstract class VectorBaseActivity<VB : ViewBinding> : AppCompatActivity(), HasScreenInjector, MvRxView { | |||
There was a problem hiding this comment.
We still use MvRxView here, and not MavericksView?
| @@ -49,7 +50,7 @@ import io.reactivex.disposables.Disposable | |||
| import timber.log.Timber | |||
| import java.util.concurrent.TimeUnit | |||
|
|
|||
| abstract class VectorBaseFragment<VB : ViewBinding> : BaseMvRxFragment(), HasScreenInjector { | |||
| abstract class VectorBaseFragment<VB : ViewBinding> : Fragment(), MvRxView, HasScreenInjector { | |||
|
Also can you add a file for the changelog please? |
…tended for external use." of MvRx `by viewModel()` calls. Maybe due to the inlining of code... This is a temporary fix...
|
FTR the allScreen sanity test is passing, but with settings test disabled due to an issue which was on develop |
ouchadam
approved these changes
Oct 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is introducing the migration to Mavericks 2.
Mavericks 2 is replacing usage of Rx by Flow internally and on the API too.
See here for more details: https://airbnb.io/mavericks/#/new-2x
So in this PR, you will find:
There is still some RxBinding and Behavior/SourceRelay to replace to finish the work.