Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/github-script from 3 to 5.1.0 #4968

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2022

Bumps actions/github-script from 3 to 5.1.0.

Release notes

Sourced from actions/github-script's releases.

v5.1.0

What's Changed

New Contributors

Full Changelog: actions/github-script@v5.0.0...v5.1.0

v5.0.0

What's Changed

Full Changelog: actions/github-script@v4.1.1...v5.0.0

v4.1.1

What's Changed

Full Changelog: actions/github-script@v4.1.0...v4.1.1

v4.1.0

What's Changed

New Contributors

Full Changelog: actions/github-script@v4.0.2...v4.1.0

Update @​actions/core package

This release updates the @actions/core package to 1.2.7 - actions/github-script#137

Fix "require" search path

Previously, the wrapped require searched the existing module.paths and then process.cwd(). We now only search process.cwd(). See actions/github-script#136 for details.

Add support for relative and npm package require

This release adds support for relative require paths, as well as requiring npm modules installed in the working directory.

Add @actions/glob package

This releases adds the @actions/glob package, which can be used in scripts via the glob variable - #127

... (truncated)

Commits
  • e3cbab9 Merge pull request #228 from actions/joshmgross/license-updates
  • 115b09e Update licenses with licensed cache
  • df46368 Use jonabc/setup-licensed in Licensed workflow
  • faea5b2 Merge pull request #216 from PeterNitscheMI/update-plugin-dependencies
  • 3825850 Update license cache
  • 7b79115 prepare release
  • f6f8024 update plugin dependencies
  • 0c6f007 Merge pull request #215 from ansgarm/patch-1
  • b3a068a fix typo
  • 00e1b58 Merge pull request #204 from actions/joshmgross/update-dev-deps
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Jan 17, 2022
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/github-script-5.1.0 branch from 76fb2e7 to ae2471e Compare January 18, 2022 13:26
@bmarty
Copy link
Member

bmarty commented Jan 18, 2022

@ariskotsomitopoulos I let you decide if we want to merge it. Last time it broke things.

@@ -74,7 +74,7 @@ jobs:
edit-mode: replace
- name: Delete comment if needed
if: always() && steps.fc.outputs.comment-id != '' && steps.ktlint-results.outputs.add_comment == 'false'
uses: actions/github-script@v3
uses: actions/github-script@v5.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a PR with the appropriate fix

@@ -51,7 +51,7 @@ jobs:
contains(github.event.issue.labels.*.name, 'A-Tags')) &&
contains(github.event.issue.labels.*.name, 'Z-Labs')
steps:
- uses: actions/github-script@v5
- uses: actions/github-script@v5.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 --> 5.1 seems fine

@bmarty
Copy link
Member

bmarty commented Jan 19, 2022

Let's close this one Github will open a new one next week, with the new rule added in #4988

EDIT I try recreate

@bmarty
Copy link
Member

bmarty commented Jan 19, 2022

@dependabot recreate

Bumps [actions/github-script](https://github.com/actions/github-script) from 3 to 5.1.0.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v3...v5.1.0)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/github-script-5.1.0 branch from ae2471e to 4ac4ec9 Compare January 19, 2022 11:26
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 19, 2022

Looks like actions/github-script is no longer being updated by Dependabot, so this is no longer needed.

@dependabot dependabot bot closed this Jan 19, 2022
@dependabot dependabot bot deleted the dependabot/github_actions/actions/github-script-5.1.0 branch January 19, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants