Fix location rendering in timeline if map cannot be loaded #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
gaelledel
approved these changes
Feb 3, 2022
bmarty
approved these changes
Feb 3, 2022
| .into(holder.staticMapImageView) | ||
| .listener(object : RequestListener<Drawable> { | ||
| override fun onLoadFailed(e: GlideException?, model: Any?, target: Target<Drawable>?, isFirstResource: Boolean): Boolean { | ||
| holder.staticMapPinImageView.setImageResource(R.drawable.ic_location_pin_failed) |
There was a problem hiding this comment.
This is maybe a design decision, but when the map fail to load, we could still draw the user avatar if available, no?
There was a problem hiding this comment.
Yes it is a design decision and it seems like a bug/ugly to use user avatar.
* develop: (54 commits) Bubbles: add CHANGELOG file Bubble: get LayoutDirection (RTL) from current Locale Version++ fastlane towncrier Version 1.3.18 changelog Improve missing state event detection to missing state events only one joined rooms (ignore LEFT room) Should reduce the number of initial sync Co-authors: ganfra and billcarsonfr Changelog added. taking the use case screen into account when accessing the sign up flows in the sanity tests updating copy split to match designs applying design feedback promoting use case strings for translation enabling the use case feature by default Code review fixes. ktlint Bubbles: clean up after review Sync: avoid deleting root event of CurrentState on gappy sync Code review fixes. Support generic location pin. ... # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageLocationItem.kt # vector/src/main/res/layout/item_timeline_event_location_stub.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5143
Figma