-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concurrency to the GitHub workflows to auto-cancel older runs of actions in PRs. #5328
Conversation
Matrix SDKIntegration Tests Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intent of PR is great, looks good.
A few nits around naming (to keep consistency), but I think we have a correctness issue with the missing matrix.target
Also wondering if we should add comments for the other workflows as well (Even if it in "sanity_test.yml" it just says run every time") so we are reminded to consider it in future.
Co-authored-by: Michael Kaye <1917473+michaelkaye@users.noreply.github.com>
Co-authored-by: Michael Kaye <1917473+michaelkaye@users.noreply.github.com>
Co-authored-by: Michael Kaye <1917473+michaelkaye@users.noreply.github.com>
…ed when making changes.
Nice suggestions @michaelkaye , thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
out of interest, what's the reasoning for needing more than the head ref? |
Groups cross workflows, so the per-workflow name is required to avoid concurrency blocking across workflows ; the instances where we use the SHA hash is to ensure multiple runs on the same workflow can happen; the instances where the matrix target is also included is when we want both sides of the target to run. (never used this before, but that was my understanding when i reviewed) |
thanks for the explanation! |
…eature/dla/ci_check_concurrency
Resolves #5327