Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Export e2ee keys] use appName instead of element #5357

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Conversation

Claire1817
Copy link
Contributor

Type of change

  • Feature
  • [] Bugfix
  • Technical
  • Other : Improvement

Content

Use the appName instead of the string "element" in the filename.

Motivation and context

In forked application like Tchap, we have "element" in the name of the file.

Screenshots / GIFs

For element debug
Screenshot_1645780114

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s): 30

Checklist

@Claire1817 Claire1817 marked this pull request as draft February 25, 2022 09:15
@github-actions
Copy link

Unit Test Results

  84 files  ±0    84 suites  ±0   1m 1s ⏱️ -8s
157 tests ±0  157 ✔️ ±0  0 💤 ±0  0 ±0 
504 runs  ±0  504 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 4860ed9. ± Comparison against base commit a1f5493.

@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="25" failures="17" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.internal]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.ordering]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="1" failures="1" errors="0" skipped="0"

@Claire1817 Claire1817 marked this pull request as ready for review February 25, 2022 10:50
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit b8a0aa7 into develop Feb 25, 2022
@bmarty bmarty deleted the cgizard/ISSUE-5326 branch February 25, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants