Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Script improvements #5471

Merged
merged 4 commits into from
Mar 21, 2022
Merged

CI Script improvements #5471

merged 4 commits into from
Mar 21, 2022

Conversation

michaelkaye
Copy link
Contributor

@michaelkaye michaelkaye commented Mar 9, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

If a test fails to run, ensure the renderer prints a suitable message
Format nightly run data in colour to be more obvious when failures occur.
Upload synapse homeserver log after run for diagnosis.
Add names to all runs

Motivation and context

General improvement to the test scripts to make it easier to understand what's going on.

Synapse homeserver logging has been removed in favour of

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@michaelkaye
Copy link
Contributor Author

This deals with part of the problem from #5470 (trying to log what's going on) and adds the coloring for #5465

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Unit Test Results

106 files  +10  106 suites  +10   1m 20s ⏱️ +10s
188 tests +16  188 ✔️ +16  0 💤 ±0  0 ±0 
622 runs  +58  622 ✔️ +58  0 💤 ±0  0 ±0 

Results for commit c687252. ± Comparison against base commit fbc3b15.

This pull request removes 8 and adds 24 tests. Note that renamed tests count towards both.
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given a selected picture when handling save selected profile picture then updates upstream avatar and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given no selected picture when saving selected profile picture then emits failure event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given upstream failure when handling display name update then emits failure event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given upstream update avatar fails when saving selected profile picture then emits failure event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when handling PostViewEvent then emits contents as view event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when handling display name update then updates upstream user display name
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when handling profile picture selected then updates selected picture state
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when handling profile picture skipped then completes personalization
im.vector.app.features.location.LocationDataTest ‑ unstablePrefixTest
im.vector.app.features.location.domain.usecase.CompareLocationsUseCaseTest ‑ given 2 far away locations when calling execute then these locations are considered as not equal
im.vector.app.features.location.domain.usecase.CompareLocationsUseCaseTest ‑ given 2 very near locations when calling execute then these locations are considered as equal
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given a selected picture, when handling save selected profile picture, then updates upstream avatar and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is not supported, when updating display name, then updates upstream user display name and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is supported, when updating display name, then updates upstream user display name and moves to choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given no selected picture, when saving selected profile picture, then emits failure event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given only supports changing profile picture, when handling PersonalizeProfile, then emits contents choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given register action ignores result, when handling action, then does nothing on success
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given register action is non loadable, when handling action, then posts next steps without loading
…

♻️ This comment has been updated with latest results.

@michaelkaye michaelkaye force-pushed the michaelk/ci_script_improvements branch from 63cbe43 to 029ccfa Compare March 10, 2022 10:24
@michaelkaye michaelkaye marked this pull request as ready for review March 10, 2022 12:22
@michaelkaye michaelkaye requested review from a team and ariskotsomitopoulos and removed request for a team March 10, 2022 12:23
@@ -308,6 +308,7 @@ jobs:
failure_screenshots/

codecov-units:
name: Unit tests with codecoverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code coverage*

@michaelkaye michaelkaye merged commit 4a8aead into develop Mar 21, 2022
@michaelkaye michaelkaye deleted the michaelk/ci_script_improvements branch March 21, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants