Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to using github action to configure synapse server in CI builds #5498

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

michaelkaye
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Rather than use a shell script to start and stop synapse, use a github action instead

Motivation and context

The synapse demo script changed which caused CI to fail, so fixing it up so it's internal to GHA rather than re-using a script not quite designed for this purpose.

Additional benefits is that this should retain the configuration and logs of the synapse homeserver for analysis after the run.

Tests

Tested by manual runs

Checklist

@github-actions
Copy link

github-actions bot commented Mar 10, 2022

Unit Test Results

  96 files  ±0    96 suites  ±0   1m 7s ⏱️ -3s
172 tests ±0  172 ✔️ ±0  0 💤 ±0  0 ±0 
564 runs  ±0  564 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 70fbcec. ± Comparison against base commit fbc3b15.

♻️ This comment has been updated with latest results.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CI seems happy too. Thanks!

@michaelkaye michaelkaye merged commit 621df9d into develop Mar 10, 2022
@michaelkaye michaelkaye deleted the michaelk/setup-matrix-synapse branch March 10, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants