"Add space" copy is replaced with "create space" in left sliding panel

[fedrunov]

Type of change

• Feature
• Bugfix
• Technical
• Other : misc

Content

Android should use "Create space" in the left panel instead of "Add Space" because "adding" suggests other actions like joining an existing space.

Motivation and context

#5516

Screenshots / GIFs

Tests

• Login/Signup
• Open left slider
• Scroll to bottom
• Check copy

Tested devices

• Physical
• Emulator
• OS version(s): A12 (API 31)

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[github-actions]

Unit Test Results

  98 files  ±0    98 suites  ±0   1m 28s ⏱️ +14s
174 tests ±0  174 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
568 runs  ±0  568 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 84bd205. ± Comparison against base commit acfeb7f.

[ericdecanini]

LGTM

[kittykat]

Ideally, the word Space should be lower cased so that it's "Create space". Is it possible to change that?

[ouchadam]

@kittykat yep it's a quick change to https://github.com/vector-im/element-android/blob/develop/vector/src/main/res/values/strings.xml#L2764

it's worth noting there are quite a few other strings which use "X Space", might be worth another ticket to update them all at the same time (would also mean we could merge this without the casing change)

[kittykat]

@kittykat yep it's a quick change to https://github.com/vector-im/element-android/blob/develop/vector/src/main/res/values/strings.xml#L2764

It looks like the string may be used in a few places so it would make sense to check that it's valid to update capitalisation everywhere

it's worth noting there are quite a few other strings which use "X Space", might be worth another ticket to update them all at the same time (would also mean we could merge this without the casing change)

Indeed

[fedrunov]

capitalisation of space is changed in different PR: #5539