Delete Events from ignored users and trigger a clear cache request dialog when unignoring user(s) #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l user without performing an initial sync each time.
…not be triggered.
bmarty
changed the title
|
Assigned to @ariskotsomitopoulos manually, since you have reviewed the previous PR #5767 and this PR reverts part of the previous change. |
bmarty
changed the title
…gnoring a user, for the change to take effect
ariskotsomitopoulos
approved these changes
Apr 20, 2022
| // See https://spec.matrix.org/latest/client-server-api/#client-behaviour-22 : | ||
| // "Once ignored, the client will no longer receive events sent by that user, with the exception of state events" | ||
| // So just delete all non-state events from our local storage. | ||
| realm.where(TimelineEventEntity::class.java) |
There was a problem hiding this comment.
Might be better to extract this functionality in TimelineEventEntityQueries.kt or TimelineEventHelper.kt. Not a blocker
There was a problem hiding this comment.
You are right. Will be handled in a dedicated PR later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring users
When users is ignored, all the Timeline Events from this user are deleted from the database.
The only remaining issue is that the timeline has to be reloaded for the change to take effect. Related (but not really closing it): #1899. Handled in 903e226Closing #1899
Unignoring user
When users are unignored, an initial sync has to be performed. Current code warn the user and perform an initial sync.
This PR handle the case where users are unignored from another session.
So:
The dialog looks like: