-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Improve location sharing service api (PSF-1004) #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaturel
changed the title
[SDK] Improve location sharing service api
[SDK] Improve location sharing service api (PSF-1004)
Jun 14, 2022
mnaturel
requested review from
a team,
onurays and
ericdecanini
and removed request for
a team
June 14, 2022 14:06
ericdecanini
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
onurays
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, LGTM!
mnaturel
force-pushed
the
feature/mna/location-sharing-service-api
branch
from
June 20, 2022 07:38
f1ca56e
to
dcca546
Compare
mnaturel
force-pushed
the
feature/mna/location-sharing-service-api
branch
from
June 20, 2022 11:06
b16ccf5
to
7ddec67
Compare
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
All location sharing related APIs have been grouped into the exposed
LocationSharingService
interface.Unit tests have been added to cover the implementation of this interface.
Motivation and context
Closes #6156
Part of #5864
Screenshots / GIFs
Tests
Tested devices
Checklist