Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Improve location sharing service api (PSF-1004) #6304

Merged
merged 18 commits into from
Jun 20, 2022

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Code refactoring

Content

All location sharing related APIs have been grouped into the exposed LocationSharingService interface.
Unit tests have been added to cover the implementation of this interface.

Motivation and context

Closes #6156
Part of #5864

Screenshots / GIFs

Tests

  • Enable live location sharing in Settings -> Labs
  • Go to a room
  • Start sharing location
  • Choose to share a static pinned location
  • Check it is correctly shared in the room
  • Start sharing location
  • Choose to share your static location
  • Check it is correctly shared in the room
  • Start sharing location
  • Choose to share your live location
  • Check it is correctly shared in the room
  • Stop the live location share
  • Check it is correctly stopped

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel changed the title [SDK] Improve location sharing service api [SDK] Improve location sharing service api (PSF-1004) Jun 14, 2022
@mnaturel mnaturel marked this pull request as ready for review June 14, 2022 13:59
@mnaturel mnaturel requested review from a team, onurays and ericdecanini and removed request for a team June 14, 2022 14:06
Copy link
Contributor

@ericdecanini ericdecanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, LGTM!

@mnaturel mnaturel force-pushed the feature/mna/location-sharing-service-api branch from f1ca56e to dcca546 Compare June 20, 2022 07:38
@mnaturel mnaturel force-pushed the feature/mna/location-sharing-service-api branch from b16ccf5 to 7ddec67 Compare June 20, 2022 11:06
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

11.8% 11.8% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit 0948cab into develop Jun 20, 2022
@mnaturel mnaturel deleted the feature/mna/location-sharing-service-api branch June 20, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Add unit tests for DefaultLocationSharingService
3 participants